gpg: Fix memory leak in sig-check.
authorWerner Koch <wk@gnupg.org>
Thu, 24 Aug 2017 18:26:19 +0000 (20:26 +0200)
committerWerner Koch <wk@gnupg.org>
Thu, 24 Aug 2017 18:26:19 +0000 (20:26 +0200)
commitb065a696344eac3007dbd5642143ecaaeebab43a
treeb5625ec70696a9c311f916d21cb9e97767a6b8f2
parent757302cc7a94633cd9bda5eb4dbe5c6e804b957b
gpg: Fix memory leak in sig-check.

* g10/sig-check.c (check_signature_over_key_or_uid): Remove useless
condition.  Actually free when SIGNER was allocated by us.
--

SIGNER_ALLOCATED never received a value of -1 but that was tested.

IF SIGNER_ALLOCATED was 2 the memory was never freed:

  if (signer_allocated == 1)
    if (signer_allocated == 2)
      free()

Fixes-commit: 44cdb9d73f1a0b7d2c8483a119b9c4d6caabc1ec

This function needs to be audited more thoroughly.

Signed-off-by: Werner Koch <wk@gnupg.org>
g10/sig-check.c