scd: Improve error handling.

* scd/app-openpgp.c (get_public_key): Improve error handling.
--
Backport master commit: 6a37b45a7f13cf5d2ae7d6c9cd796a4bd197b80d

Found using the Clang Static Analyzer.

Signed-off-by: Justus Winter <justus@g10code.com>

diff --git a/scd/app-openpgp.c b/scd/app-openpgp.c
index 291700f..59ccd6d 100644 (file)
--- a/scd/app-openpgp.c
+++ b/scd/app-openpgp.c
@@ -1362,7 +1362,7 @@ get_public_key (app_t app, int keyno)
   xfree (buffer);
   xfree (mbuf);
   xfree (ebuf);
-  return 0;
+  return err;
 }
 #endif /* GNUPG_MAJOR_VERSION > 1 */