avoid future chance of using uninitialized memory
authorDaniel Kahn Gillmor <dkg@fifthhorseman.net>
Fri, 19 Dec 2014 22:53:36 +0000 (17:53 -0500)
committerNIIBE Yutaka <gniibe@fsij.org>
Tue, 13 Jan 2015 02:06:43 +0000 (11:06 +0900)
* util/iobuf.c: (iobuf_open): initialize len

--

Cherry-pick 367b073ab5f439ccf0750461d10c69f36998bd62.

In iobuf_open, IOBUFCTRL_DESC and IOBUFCTRL_INIT commands are invoked
(via file_filter()) on fcx, passing in a pointer to an uninitialized
len.

With these two commands, file_filter doesn't actually do anything with
the value of len, so there's no actual risk of use of uninitialized
memory in the code as it stands.

However, some static analysis tools might flag this situation with a
warning, and initializing the value doesn't hurt anything, so i think
this trivial cleanup is warranted.

Debian-Bug-Id: 773469

util/iobuf.c

index 35de020..a330460 100644 (file)
@@ -1107,7 +1107,7 @@ iobuf_open( const char *fname )
     IOBUF a;
     FILEP_OR_FD fp;
     file_filter_ctx_t *fcx;
-    size_t len;
+    size_t len = 0;
     int print_only = 0;
     int fd;