gpgol.git
13 months agoFix missing space in german translation of version
Andre Heinecke [Fri, 31 Aug 2018 12:23:36 +0000 (14:23 +0200)]
Fix missing space in german translation of version

* po/de.po: Add ending space.

13 months agoPost release version bump
Andre Heinecke [Fri, 31 Aug 2018 11:24:41 +0000 (13:24 +0200)]
Post release version bump

--

13 months agoUpdate NEWS for todays release gpgol-2.3.0
Andre Heinecke [Fri, 31 Aug 2018 11:19:48 +0000 (13:19 +0200)]
Update NEWS for todays release

--

13 months agoTranslate the word "technical"
Andre Heinecke [Thu, 30 Aug 2018 13:01:38 +0000 (15:01 +0200)]
Translate the word "technical"

* po/de.po, po/nl.po, po/pt.po: Translate technical in the
100% languages.

13 months agoAuto update po files
Andre Heinecke [Thu, 30 Aug 2018 12:58:56 +0000 (14:58 +0200)]
Auto update po files

* po/*: update

13 months agoRevert "Check for PGP/Inline inside of S/MIME mails"
Andre Heinecke [Thu, 30 Aug 2018 12:41:16 +0000 (14:41 +0200)]
Revert "Check for PGP/Inline inside of S/MIME mails"

This reverts commit 1656e01d2eb19c8349dcab9d9b7e25fb85b9c854.

13 months agoRevert "Also check for pgp/inline in IPM.Note.SMIME"
Andre Heinecke [Thu, 30 Aug 2018 12:41:08 +0000 (14:41 +0200)]
Revert "Also check for pgp/inline in IPM.Note.SMIME"

This reverts commit 0e05606f693114b491a74030e7ae54c75738eeae.

13 months agoAdd a debug statement when marking MOSS attachs
Andre Heinecke [Thu, 30 Aug 2018 07:45:59 +0000 (09:45 +0200)]
Add a debug statement when marking MOSS attachs

* src/mapihelp.cpp (mapi_mark_moss_attach, mapi_body_to_attachment):
Add debug.

13 months agoAlso check for pgp/inline in IPM.Note.SMIME
Andre Heinecke [Thu, 30 Aug 2018 07:44:43 +0000 (09:44 +0200)]
Also check for pgp/inline in IPM.Note.SMIME

* src/mapihelp.cpp (mapi_change_message_class): Also check
for inline in IPM.Note.SMIME

GnuPG-Bug-Id: T4115

13 months agoCheck for PGP/Inline inside of S/MIME mails
Andre Heinecke [Thu, 30 Aug 2018 07:39:45 +0000 (09:39 +0200)]
Check for PGP/Inline inside of S/MIME mails

* src/mapihelp.cpp
(change_message_class_ipm_note_smime_multipartsigned): Check for
PGP/Inline if S/MIME is disabled.

--
This is a hack to handle the case where some crypto gateway
might wrap a PGP Inline message inside an S/MIME message.

GnuPG-Bug-Id: T4115

13 months agoFix minor german l10n error
Andre Heinecke [Thu, 30 Aug 2018 06:27:21 +0000 (08:27 +0200)]
Fix minor german l10n error

--

13 months agoCache icons
Andre Heinecke [Wed, 29 Aug 2018 09:28:15 +0000 (11:28 +0200)]
Cache icons

* src/ribbon-callbacks.cpp (getIcon): Use dispcache.
(getIconDisp): New.

--
While this may not be much it felt excessive to initialize
GDIPlus and convert the icon from PNG to bitmap for each
getIcon call even though the icons never change over
the lifetime of GpgOL

GnuPG-Bug-Id: T4113

13 months agoAccept sent on behalf of as the sender address
Andre Heinecke [Wed, 29 Aug 2018 09:02:52 +0000 (11:02 +0200)]
Accept sent on behalf of as the sender address

* src/mail.cpp (Mail::updateOOMData_o): Cache sent on behalf.
(Mail::updateSigstate): Fallback to sent on behalf.
(m_sent_on_behalf): New cache variable.
* src/oomhelp.cpp (get_sender_SentRepresentingAddress): New.

--
Outlook clearly shows in the mail:
"foo@bar.baz at behalf of foo2@bar.baz"

So we can accept "foo2@bar.baz" also as the sender address
as it is visible.

GnuPG-Bug-ID: T4110

13 months agoFix minor locking issue
Andre Heinecke [Wed, 29 Aug 2018 08:37:11 +0000 (10:37 +0200)]
Fix minor locking issue

* src/keycache.cpp (KeyCache::Private::getByFpr): Use a copy
to return after unlocking the map.

--
I'm not sure if this is neccessary as the iterator is const
but better be safe.

13 months agoUse dispcache for Multilanguage COM interface
Andre Heinecke [Wed, 29 Aug 2018 08:30:02 +0000 (10:30 +0200)]
Use dispcache for Multilanguage COM interface

* src/dialogs.h (DISPID_MULTILANG): New.
* src/mlang-charset.cpp (ansi_charset_to_utf8): Use dispcache.

--
Using CoCreateInstance for every string to convert seemed excessive
so we better cache it.

GnuPG-Bug-Id: T4114

13 months agoAdd generic cache for IDispatch objects
Andre Heinecke [Wed, 29 Aug 2018 08:24:14 +0000 (10:24 +0200)]
Add generic cache for IDispatch objects

* src/dispcache.cpp, src/dispcache.h: New.
* src/gpgoladdin.cpp, src/gpgoladdin.h: Carry dispcache as
member.
* src/Makefile.am: Add new Files.

--
The cache shares the lifetime of the addin object and
can be used to keep IDispatch object around without having
to create them again and again.

13 months agoAdd missing word from config dialog to i18n
Andre Heinecke [Wed, 29 Aug 2018 08:14:10 +0000 (10:14 +0200)]
Add missing word from config dialog to i18n

* src/addin-options.cpp: Add (Technical)

13 months agoRemove attic
Andre Heinecke [Wed, 29 Aug 2018 07:10:13 +0000 (09:10 +0200)]
Remove attic

* src/attic.c: Deleted.

--
This was dead / old code that was just confusing to have
lying around.

13 months agoUpdate NEWS
Andre Heinecke [Tue, 28 Aug 2018 12:22:25 +0000 (14:22 +0200)]
Update NEWS

--

13 months agoMinor indentation fix
Andre Heinecke [Tue, 28 Aug 2018 11:59:54 +0000 (13:59 +0200)]
Minor indentation fix

--

13 months agoImprove keycache performance a bit
Andre Heinecke [Tue, 28 Aug 2018 10:20:55 +0000 (12:20 +0200)]
Improve keycache performance a bit

* src/keycache.cpp: Use unordered_map and set for better
speed.

13 months agoAdd another tracepoint in parsing_done
Andre Heinecke [Tue, 28 Aug 2018 10:15:24 +0000 (12:15 +0200)]
Add another tracepoint in parsing_done

* src/mail.cpp (Mail::parsing_done): Add tracepoint.

13 months agoUse keycache instead of Signature::Key
Andre Heinecke [Tue, 28 Aug 2018 10:13:19 +0000 (12:13 +0200)]
Use keycache instead of Signature::Key

* src/mail.cpp (Mail::updateSigstate),
(Mail::getCryptoDetails_o): Use keycache.
* src/parsecontroller.cpp (Parsecontroller::parse): Use
keycache.

--
This is a huge performance improvement as the old code
was pretty bad. The old code did three keylistings
after a verify to search the key, then check if the
key is secret and then update the key.

13 months agoExtend keycache for fingerprint lookup
Andre Heinecke [Tue, 28 Aug 2018 10:11:23 +0000 (12:11 +0200)]
Extend keycache for fingerprint lookup

* src/keycache.cpp, src/keycache.h (KeyCache::update),
(KeyCache::getByFpr): New.

--
This extends the keycache with a generic fingerprint
to key mapping. Update inserts or updates a key
in the keycache, getByFpr is the main accessor.

13 months agoFix confusing debug output
Andre Heinecke [Tue, 28 Aug 2018 10:10:18 +0000 (12:10 +0200)]
Fix confusing debug output

* src/windowmessages.cpp (delayed_invalidate_ui): Print
waiting before sleep, not after.

13 months agoChange mime data log category
Andre Heinecke [Thu, 23 Aug 2018 07:21:41 +0000 (09:21 +0200)]
Change mime data log category

* src/mimedataprovider.cpp: Change data logging from
log_mime_parser to log_mime_data.

13 months agoIgnore disable async crypto option
Andre Heinecke [Wed, 22 Aug 2018 11:33:11 +0000 (13:33 +0200)]
Ignore disable async crypto option

* src/mail.cpp (Mail::isAsyncCryptDisabled): We assume
that Async crypto is now stable. So ignore this option.

--
We assume that T3838 is fixed.

GnuPG-Bug-Id: T3838

13 months agoFix is_valid_chksum check
Andre Heinecke [Wed, 22 Aug 2018 11:30:35 +0000 (13:30 +0200)]
Fix is_valid_chksum check

* src/parsecontroller.cpp (is_valid_checksum): Don't check
the OR'ed sigsum values for equality.

--
This fixes handling of "Green Valid" S/MIME mails.

13 months agoMake autosecure compatible with always sign
Andre Heinecke [Wed, 22 Aug 2018 11:28:32 +0000 (13:28 +0200)]
Make autosecure compatible with always sign

* src/mail.cpp (Mail::setDoAutosecure_m): Handle always
sign and do not treat it as manual setting.

--
It makes sense for users who always sign to still encrypt
based on key availablity.

13 months agoFix minor name inconsitencs
Andre Heinecke [Wed, 22 Aug 2018 08:59:57 +0000 (10:59 +0200)]
Fix minor name inconsitencs

* src/mail.cpp (releaseCurrentItem): m_tmp was not a member.

13 months agoFix potential crash in T3656 workaround
Andre Heinecke [Wed, 22 Aug 2018 08:51:42 +0000 (10:51 +0200)]
Fix potential crash in T3656 workaround

* src/windowmessages.cpp (CLOSE): Use the currentViewRef trick
to avoid unload in close.

--
The workaround codepath crashed reliably for me with the
async sending. But with the current item ref trick it no
longer crashes as the unload is later. My observation is
that any Invoke that triggers an Unload can crash so we
better avoid it.

GnuPG-Bug-Id: T3656

13 months agoWKS: Handle aborted confirmation process better
Andre Heinecke [Wed, 22 Aug 2018 08:26:58 +0000 (10:26 +0200)]
WKS: Handle aborted confirmation process better

* src/wks-helper.cpp (handle_confirmation_notify): Go back a
state if we have not seen a confirmation in this run.

13 months agoRewrite cached key resolution
Andre Heinecke [Wed, 22 Aug 2018 08:20:20 +0000 (10:20 +0200)]
Rewrite cached key resolution

* src/cryptcontroller.cpp (resolve_through_protocol): New.
(resolve_keys_cached): Use new helper function.

--
The old code was too much spaghetti and several issues. E.g.
it could select a CMS Signing key with OpenPGP Encryption
keys. Or would not support fallback to S/MIME if OpenPGP
encryption was possible but only an S/MIME signing key available.

13 months agoAdd helper to print out protocol
Andre Heinecke [Wed, 22 Aug 2018 08:19:27 +0000 (10:19 +0200)]
Add helper to print out protocol

* src/cpphelp.cpp, src/cpphelp.h (to_string): New.

--
It's in cpphelp as I plan to have some more overloads of
this.

14 months agoFix crash on async send in OL 2013
Andre Heinecke [Fri, 10 Aug 2018 09:38:01 +0000 (11:38 +0200)]
Fix crash on async send in OL 2013

* src/mail.cpp, src/mail.h (Mail::

14 months agoDisable super verbose debug output
Andre Heinecke [Fri, 10 Aug 2018 08:39:02 +0000 (10:39 +0200)]
Disable super verbose debug output

* src/w32-gettext.h: Disable very verbose debug output.

14 months agoAdd new function to check for preview pane
Andre Heinecke [Thu, 9 Aug 2018 12:11:58 +0000 (14:11 +0200)]
Add new function to check for preview pane

* src/oomhelp.cpp, src/oomhelp.h (is_preview_pane_visible): New.
* src//ribbon-callbacks.cpp (get_mail_from_control): Use it.

--
This should hopefully work on all outlook versions.

14 months agoAdd ref in get_strong_reference
Andre Heinecke [Thu, 9 Aug 2018 12:11:20 +0000 (14:11 +0200)]
Add ref in get_strong_reference

* src/oomhelp.cpp (get_strong_reference): Mark add ref.

14 months agoUse utf8 gettext in ribbon callbacks
Andre Heinecke [Thu, 9 Aug 2018 12:10:39 +0000 (14:10 +0200)]
Use utf8 gettext in ribbon callbacks

* src/ribbon-callbacks.cpp: Use utf8 gettext.

--
The outlook ribbon UI uses utf8

14 months agoMerge remote-tracking branch 'dutch-l10n/dutch'
Andre Heinecke [Tue, 7 Aug 2018 06:51:27 +0000 (08:51 +0200)]
Merge remote-tracking branch 'dutch-l10n/dutch'

14 months agopo: Update pt translation
Andre Heinecke [Tue, 7 Aug 2018 06:50:13 +0000 (08:50 +0200)]
po: Update pt translation

* po/pt.po: Update

--
Provided again by Marco. Thanks.

14 months agoMake send_message_to_ui_thread private
Andre Heinecke [Mon, 6 Aug 2018 08:47:24 +0000 (10:47 +0200)]
Make send_message_to_ui_thread private

* src/windowmessages.cpp, src/windowmessages.h
(send_msg_to_ui_thread): Make it static

--
Helps reviewing code to check if the wm_ctx_t is always valid.

14 months agoUpdate Dutch translation
Erwin Bronkhorst [Wed, 27 Jun 2018 20:13:05 +0000 (22:13 +0200)]
Update Dutch translation

14 months agomalloc -> xmalloc
Andre Heinecke [Tue, 24 Jul 2018 12:09:10 +0000 (14:09 +0200)]
malloc -> xmalloc

* src/w32-gettext.cpp (bindtextdomain): Change a spurious malloc
to xmalloc.

--
Fixes a memdbg error.

14 months agoMinor cleanups
Andre Heinecke [Tue, 24 Jul 2018 09:07:45 +0000 (11:07 +0200)]
Minor cleanups

* src/cryptcontroller.cpp, src/cryptcontroller.h: m_recipents is
now a vector.

14 months agoFix memory leak when opening options
Andre Heinecke [Tue, 24 Jul 2018 09:06:56 +0000 (11:06 +0200)]
Fix memory leak when opening options

* src/addin-options.cpp (open_gpgolgui): Release cArray.

14 months agoAuto update german po file formatting
Andre Heinecke [Tue, 24 Jul 2018 08:25:17 +0000 (10:25 +0200)]
Auto update german po file formatting

* po/de.po: Update.

14 months agoFix return value of is_crypt_pressed
Andre Heinecke [Tue, 24 Jul 2018 08:24:34 +0000 (10:24 +0200)]
Fix return value of is_crypt_pressed

* src/ribbon-callbacks.cpp (get_crypt_pressed): Fix return
value.

14 months agoFix w64 build
Andre Heinecke [Tue, 24 Jul 2018 08:06:56 +0000 (10:06 +0200)]
Fix w64 build

* src/windowmessages.cpp (delayed_invalidate_ui): Cast delay
to intptr_t before casting to int.

14 months agoUpdate german translation
Andre Heinecke [Tue, 24 Jul 2018 07:32:28 +0000 (09:32 +0200)]
Update german translation

* po/de.po: Update

14 months agoAuto update po files
Andre Heinecke [Tue, 24 Jul 2018 07:23:13 +0000 (09:23 +0200)]
Auto update po files

* po: Update

14 months agoReturn 0 for handled WindowMessages
Andre Heinecke [Tue, 24 Jul 2018 06:10:29 +0000 (08:10 +0200)]
Return 0 for handled WindowMessages

* src/windowmessages.cpp (gpgol_window_proc): Return 0 for
messages handled by us.

--
Does not make sense to call the defaultwindowproc for our
own messages.

14 months agoTrace timing of sig key request
Andre Heinecke [Tue, 24 Jul 2018 06:09:42 +0000 (08:09 +0200)]
Trace timing of sig key request

* src/parsecontroller.cpp (ParseController::parse): Add tracepoints.

14 months agoLog invalid skipped secret keys
Andre Heinecke [Tue, 24 Jul 2018 06:08:02 +0000 (08:08 +0200)]
Log invalid skipped secret keys

* src/keycache.cpp (locate_secret): Log invalid skipped keys.

--
This might help in debug output if autoencrypt does not
work for some.

14 months agoPrint parsed mail count in dbg output
Andre Heinecke [Tue, 24 Jul 2018 06:06:58 +0000 (08:06 +0200)]
Print parsed mail count in dbg output

* src/mail.cpp (Mail::updateBody_o): Print parsed mail
count.

14 months agoFix orig body memleak in decryptVerify
Andre Heinecke [Mon, 23 Jul 2018 14:32:32 +0000 (16:32 +0200)]
Fix orig body memleak in decryptVerify

* src/mail.cpp (Mail::decryptVerify_o): Don't assign
heap alloced data to std::string without free.

14 months agoFix memleak of plain body in collect_data
Andre Heinecke [Mon, 23 Jul 2018 14:31:45 +0000 (16:31 +0200)]
Fix memleak of plain body in collect_data

* src/cryptcontroller.cpp (CryptController::collect_data): Fix
leak.

14 months agoFix important memleak in get_mail_from_control
Andre Heinecke [Mon, 23 Jul 2018 14:09:51 +0000 (16:09 +0200)]
Fix important memleak in get_mail_from_control

* src/ribbon-callbacks.cpp (get_mail_from_control): Fix memleak.

--
This function is called 4 times for each invalidate UI so this
leak is important even if it just leaks a few bytes.

14 months agoImprove wchar and utf8 conversion memdbg
Andre Heinecke [Mon, 23 Jul 2018 14:08:52 +0000 (16:08 +0200)]
Improve wchar and utf8 conversion memdbg

* src/w32-gettext.h (wchar_to_utf8, utf8_to_wchar): replace
by logging macros.

14 months agoRemove dead code
Andre Heinecke [Mon, 23 Jul 2018 14:07:57 +0000 (16:07 +0200)]
Remove dead code

* src/mail.cpp, src/mail.h (getHTMLBody_o): Removed.

14 months agoMinor initialzation
Andre Heinecke [Mon, 23 Jul 2018 14:07:09 +0000 (16:07 +0200)]
Minor initialzation

* src/mail.cpp (Mail::decryptVerify_o): Initialize placeholder.

14 months agoFix super minor memleak
Andre Heinecke [Mon, 23 Jul 2018 14:06:35 +0000 (16:06 +0200)]
Fix super minor memleak

* src/gpgoladdin.cpp (GpgolAddin::OnConnection): Release
version.

14 months agoFix memleak in put_pa_string
Andre Heinecke [Mon, 23 Jul 2018 13:34:35 +0000 (15:34 +0200)]
Fix memleak in put_pa_string

* src/oomhelp.cpp (put_pa_string): Fix memleak.

--
Its a definitve but not a major or critical memleak. In a usual
setup this would leak ~32 Bytes per mail.

14 months agoAdd caller debugging for wchar / utf8 convs
Andre Heinecke [Mon, 23 Jul 2018 13:24:22 +0000 (15:24 +0200)]
Add caller debugging for wchar / utf8 convs

* src/w32-gettext.cpp, src/w32-gettext.h (utf8_to_wchar),
(wchar_to_utf8): Improve tracing for memory debug.

--
We have some leaks here.

14 months agoUse static references for VARAINT_BOOL | BYREF
Andre Heinecke [Mon, 23 Jul 2018 13:22:25 +0000 (15:22 +0200)]
Use static references for VARAINT_BOOL | BYREF

* src/ribbon-callbacks.cpp (get_crypt_pressed),
(get_is_details_enabled, get_is_crypto_mail): Reference a static.

--
I really don't understand it but malloc'ing also seems wrong
as we leak heap mem here.
These references to static variables appear to work.

14 months agoFix unlikely error memleak
Andre Heinecke [Mon, 23 Jul 2018 13:21:14 +0000 (15:21 +0200)]
Fix unlikely error memleak

* src/mapihel.cpp (mapi_get_message_content_type): Fix error
handling meleak.

14 months agoPoor redmond man's valgrind
Andre Heinecke [Mon, 23 Jul 2018 12:01:16 +0000 (14:01 +0200)]
Poor redmond man's valgrind

* src: Use x functions
* src/xmalloc.h: Provide macros for memdbg.

14 months agoFix tmp path naming if name exists
Andre Heinecke [Mon, 23 Jul 2018 11:54:27 +0000 (13:54 +0200)]
Fix tmp path naming if name exists

* src/common.cpp (get_tmp_outfile): Fix name.

14 months agostrdup -> xstrdup
Andre Heinecke [Mon, 23 Jul 2018 11:04:34 +0000 (13:04 +0200)]
strdup -> xstrdup

--

14 months agoRemove unused code
Andre Heinecke [Mon, 23 Jul 2018 07:42:59 +0000 (09:42 +0200)]
Remove unused code

* src/main.c (create_initialization_vector)
(get_crypt_random): Removed.

14 months agoMake async encryption optional
Andre Heinecke [Mon, 23 Jul 2018 07:31:51 +0000 (09:31 +0200)]
Make async encryption optional

* src/common_indep.h (opt): Add sync_enc.
* src/mail.cpp (Mail::isAsynCryptDisabled_o): Respect it.
* src/main.c (read_options): Read it.

--
If we have users where GpgOL crashes on send we or the
user might want to disable async encryption.

GnuPG-Bug-Id: T3838

14 months agoImprove invalidation blocking
Andre Heinecke [Mon, 23 Jul 2018 06:15:30 +0000 (08:15 +0200)]
Improve invalidation blocking

* src/mail.cpp (do_parsing): Don't use invalidation_lock. We now have
block invalidation.
* src/mailitem-events.cpp (Read): Delay invalidate.
* src/windowmessages.cpp (delayed_invalidate_ui): Take sleep param.
(INVALIDATE_UI): Respect invalidation blocked.
* src/windowmessages.h: Update accordingly.

--
This works much better then the try to archive minimizing
invalidations by using a lock.

14 months agoTrace return of UI callbacks
Andre Heinecke [Mon, 23 Jul 2018 06:12:16 +0000 (08:12 +0200)]
Trace return of UI callbacks

* src/ribbon-callbacks.cpp: Trace returns.

--
These functions are often times the last functions in the
log of a crash as they are called whenever the UI changed.
There is no crash in them but to better see it anway we
log when they are done.

14 months agoFix invalidate UI only on unselect
Andre Heinecke [Mon, 23 Jul 2018 06:09:26 +0000 (08:09 +0200)]
Fix invalidate UI only on unselect

* src/explorer-events.cpp (start_watchdog): Only invalidate
UI on unselect.

14 months agounique_ptr++
Andre Heinecke [Mon, 23 Jul 2018 06:08:06 +0000 (08:08 +0200)]
unique_ptr++

* src/parsecontroller.cpp (ParseController::get_ultimate_keys): Use
unique ptr for context.

14 months agoFix make dist
Andre Heinecke [Fri, 20 Jul 2018 13:52:52 +0000 (15:52 +0200)]
Fix make dist

* po/POTFILES.in: Update file list.

14 months agoNext version will be 2.3.0
Andre Heinecke [Fri, 20 Jul 2018 13:52:09 +0000 (15:52 +0200)]
Next version will be 2.3.0

* configure.ac: Bump minor version.

--
Lots of traumatic changes.

14 months agoDon't print error in memdbg if caller changes
Andre Heinecke [Fri, 20 Jul 2018 13:24:11 +0000 (15:24 +0200)]
Don't print error in memdbg if caller changes

* src/memdbg.cpp (register_name): Don't print error
if the name changed and the calling function was used as the name.

14 months agoMake UI invalidation more deterministic
Andre Heinecke [Fri, 20 Jul 2018 13:21:34 +0000 (15:21 +0200)]
Make UI invalidation more deterministic

* src/explorer-events.cpp (hasSelection, startWatchdog, changeSeen):
New.
* src/mail.cpp (do_parsing): Block invalidation while parsing.
* src/windowmessages.cpp (blockInv, unblockInv): New.
(delayed_invalidate_ui): Handle block inv state.
* src/windowmessages.h: Update accordingly.

--
UI Invalidation is extremly expensive and often a cause for
crashes. So we should avoid it as much as possible. This
code aims just to do that while still not skipping any
required invalidation.

14 months agoAdd tracing for update body
Andre Heinecke [Fri, 20 Jul 2018 13:00:05 +0000 (15:00 +0200)]
Add tracing for update body

* src/mail.cpp (Mail::updateBody_o): Trace calls.

--
This seems to hang sometimes so lets make sure that it
is actually the oom call that hangs.

14 months agoPrint error if addin is accessed after shutdown
Andre Heinecke [Fri, 20 Jul 2018 12:58:15 +0000 (14:58 +0200)]
Print error if addin is accessed after shutdown

* src/gpgoladdin.cpp (GpgolAddin::get_instace): Print error
when accessed.

--
I thought this might be happening.

14 months agoImplement cpp ctor / dtor counting
Andre Heinecke [Fri, 20 Jul 2018 12:57:34 +0000 (14:57 +0200)]
Implement cpp ctor / dtor counting

* src/memdbg.cpp (memdbg_ctor, memdbg_dtor): Implement.

14 months agoUse reffing function as name for IUnknown
Andre Heinecke [Fri, 20 Jul 2018 12:55:27 +0000 (14:55 +0200)]
Use reffing function as name for IUnknown

* src/memdbg.cpp (_memdbg_addRef, register_name): Use
calling function as the name for IUnknwon refs.

--
This is very useful to see at a glance which refs are
open. E.g. to see the event sink references.

14 months agoAdd simple dtor / ctor counting of Cpp objs
Andre Heinecke [Fri, 20 Jul 2018 12:53:53 +0000 (14:53 +0200)]
Add simple dtor / ctor counting of Cpp objs

--
This adds memdbg trace function to the important objects
to double check that we don't loose / leak any.

14 months agoAccept multipart/mixed application/pgp-encrypted
Andre Heinecke [Fri, 20 Jul 2018 12:51:30 +0000 (14:51 +0200)]
Accept multipart/mixed application/pgp-encrypted

* src/mapihelp.cpp (change_message_class_ipm_note): Accept
multipart/mixed with protocol application/pgp-encrypted.

--
This happens when an encrypted mail is moved by Outlooks
local filter move rules.

GnuPG-Bug-Id: T4070

14 months agoRemove dead code and add some addRefs
Andre Heinecke [Fri, 20 Jul 2018 12:01:43 +0000 (14:01 +0200)]
Remove dead code and add some addRefs

* src/mapihel.cpp, src/mapihelp.h (has_gpgol_body_name)
(mapi_get_gpgol_body_attachment, mapi_delete_gpgol_body_attachment),
(mapi_attachment_to_body): Removed.

14 months agoFix ref leak on no object error
Andre Heinecke [Fri, 20 Jul 2018 11:15:49 +0000 (13:15 +0200)]
Fix ref leak on no object error

* src/oomhelp.cpp (get_oom_object): Release pDisp always.

--
This fixes a common reference leak from the check_inline_response
codepath. Where it would leak for everything that is not an
inline response.

14 months agoFix minor ref leaks
Andre Heinecke [Fri, 20 Jul 2018 10:04:50 +0000 (12:04 +0200)]
Fix minor ref leaks

* src/oomhelp.cpp (get_account_for_mail): Release account.
(ensure_category_exists): Release categories on error.

14 months agoFix ref leak in get_oom_recipients
Andre Heinecke [Fri, 20 Jul 2018 10:04:10 +0000 (12:04 +0200)]
Fix ref leak in get_oom_recipients

* src/oomhelp.cpp (get_oom_recipients): Release addrEntry.

14 months agoAdd missing memdbg_addRefs
Andre Heinecke [Fri, 20 Jul 2018 10:03:03 +0000 (12:03 +0200)]
Add missing memdbg_addRefs

* src/mapihelp.cpp (mapi_get_attach): Add missing addRef.
* src/mimemaker.cpp (create_mapi_attachment): Ditto.

14 months agoAdd ptr and line to addRef dbg output
Andre Heinecke [Fri, 20 Jul 2018 10:02:10 +0000 (12:02 +0200)]
Add ptr and line to addRef dbg output

* src/memdbg.h (memdbg_addRef): Debug out the line.

--
This makes it easy to find where leaked objects were
referenced.

14 months agoFix attach table leak
Andre Heinecke [Fri, 20 Jul 2018 10:01:23 +0000 (12:01 +0200)]
Fix attach table leak

* src/cryptcontroller.cpp (CryptController::collect_data): Fix
table leak.

14 months agoFix ref leak in setDoAutosecure_m
Andre Heinecke [Fri, 20 Jul 2018 09:18:34 +0000 (11:18 +0200)]
Fix ref leak in setDoAutosecure_m

* src/mail.cpp (Mail::setDoAutosecure_m): Release msg.

14 months agoFix big reference leak of cipherstream / message
Andre Heinecke [Fri, 20 Jul 2018 08:48:02 +0000 (10:48 +0200)]
Fix big reference leak of cipherstream / message

* src/mail.cpp (get_attachment_stream_o): Release
message and mapi_attachment after obtaining the stream.

--
This is a big leak. It probably means that Outlook kept
the original Message fully in the memory.

For this the memdbg interface might already be worth it.

14 months agoImprove memdbg name output
Andre Heinecke [Fri, 20 Jul 2018 08:46:13 +0000 (10:46 +0200)]
Improve memdbg name output

* src/memdbg.cpp (register_name): Handle name changes.
(memdbg_addRef): Handle name change.

14 months agoChange an error to debug
Andre Heinecke [Fri, 20 Jul 2018 08:45:00 +0000 (10:45 +0200)]
Change an error to debug

* src/mail.cpp (Mail::installFolderEventHandler_o): Don't
print the success message as error.

14 months agoUnref application unload / shutdown
Andre Heinecke [Fri, 20 Jul 2018 08:43:02 +0000 (10:43 +0200)]
Unref application unload / shutdown

* src/gpgoladdin.cpp (GpgolAddin::shutdown): Release
application.

--
Minor and should not have been a problem.

14 months agoFix reference error on Explorer / Explorers object
Andre Heinecke [Fri, 20 Jul 2018 08:40:40 +0000 (10:40 +0200)]
Fix reference error on Explorer / Explorers object

* src/gpgoladdin.cpp (install_explorer_sinks): Release
explorer and explorers after installing the sinks.

--
The sinks handle the ref counting by themself. The
reference leak should be not a real problem because
the sinks keep them anyway until the end of the
program.

14 months agoAdd memdbg handling for MAPI
Andre Heinecke [Fri, 20 Jul 2018 08:34:00 +0000 (10:34 +0200)]
Add memdbg handling for MAPI

* src/gpgoladdin.cpp (GpgolAddin::OnConnection): Ref application.
* src/mapihelp.cpp: Replace OpenProperty by gpgol_openProperty.
memdbg_addRef for some MAPI functions that return an object.
* src/mimemaker.cpp: Replace OpenProperty by gpgol_openProperty.
* src/mlang-charset.cpp (ansi_charset_to_utf8): Mark multilang
as reffed.
* src/olflange.cpp (install_forms): Mark formcontainer as reffed.
* src/oomhelp.cpp, src/oomhelp.h (gpgol_queryInterface): New.
(get_oom_iunknown): Add ref.
(get_oom_base_message_from_mapi): Add ref.
* src/ribbon-callbacks.cpp (getIcon): Add ref on stream and
change it to be automatically freed as we don't free it.

14 months agoImprove GpgolAddin debug output
Andre Heinecke [Fri, 20 Jul 2018 08:30:23 +0000 (10:30 +0200)]
Improve GpgolAddin debug output

* src/gpgoladdin.cpp (DllCanUnloadNow): Trace call.
(GpgolRibbonExtender::~GpgolRibbonExtender): Dump memory map.
(GpgolAddinFactory::~GpgolAddinFactory): Debug dtor.